Create OpenShift dashboard to visualize Collector metrics #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
reviewed
May 29, 2024
pavolloffay
reviewed
Jun 4, 2024
pavolloffay
reviewed
Jun 25, 2024
pavolloffay
reviewed
Jul 3, 2024
…try#2995 Signed-off-by: Israel Blancas <[email protected]>
|
@pavolloffay anything else? |
pavolloffay
reviewed
Jul 9, 2024
…or into feature/2995
Signed-off-by: Israel Blancas <[email protected]>
pavolloffay
approved these changes
Jul 9, 2024
| "k8s.io/client-go/kubernetes" | ||
| ) | ||
|
|
||
| // The dashboard is created manually following the syntax from Grafana 5. For development purposes, this dashboard can be created just loading the JSON file |
Signed-off-by: Israel Blancas <[email protected]>
pavolloffay
approved these changes
Jul 10, 2024
swiatekm
reviewed
Jul 10, 2024
pavolloffay
reviewed
Jul 15, 2024
jaronoff97
reviewed
Jul 15, 2024
Signed-off-by: Israel Blancas <[email protected]>
jaronoff97
approved these changes
Jul 15, 2024
|
@swiatekm could you please review? |
frzifus
approved these changes
Jul 17, 2024
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: To enable this feature, you need to specify the `--create-openshift-dashboard` argument to the operator |
There was a problem hiding this comment.
Does it make sense to start openshift specific flags with an --openshift-* prefix?
There was a problem hiding this comment.
I think it's a nice idea :)
|
@swiatekm please, can you review? |
swiatekm
approved these changes
Jul 18, 2024
…rator into feature/2995
Signed-off-by: Israel Blancas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: this PR adds the creation of OpenShift dashboards to monitor OpenTelemetry Collector instances.