Create a separate bundle for OpenShift installations #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
changed the title
|
Could you please create a changelog entry for this? |
pavolloffay
reviewed
Jun 25, 2024
config/manifests/community/bases/opentelemetry-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
|
The contributing.md should be probably updated as well |
Sure. I'll do. |
iblancasa
changed the title
swiatekm
reviewed
Jun 25, 2024
config/manifests/community/bases/opentelemetry-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
pavolloffay
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Nice progress 👍🏼
https://github.com/open-telemetry/opentelemetry-operator/blob/main/CONTRIBUTING.md#create-the-bundle-and-related-images needs to be updated as well.
iblancasa
force-pushed
the
feature/3054
branch
2 times, most recently
from
085c776
to
b481724
Compare
pavolloffay
reviewed
Jul 8, 2024
Signed-off-by: Israel Blancas <[email protected]>
pavolloffay
reviewed
Jul 15, 2024
pavolloffay
approved these changes
Jul 16, 2024
|
@jaronoff97 @swiatekm could you please review? |
jaronoff97
reviewed
Jul 16, 2024
jaronoff97
approved these changes
Jul 16, 2024
Signed-off-by: Israel Blancas <[email protected]>
…or into feature/3054
jaronoff97
approved these changes
Jul 16, 2024
swiatekm
approved these changes
Jul 17, 2024
frzifus
approved these changes
Jul 17, 2024
|
Could we merge? |
|
@iblancasa could you please resolve conflicts? |
…or into feature/3054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: create a separate bundle for OpenShift platform.
Resolves: #3054