-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App for TA collector mtls e2e tests #3120
base: main
Are you sure you want to change the base?
App for TA collector mtls e2e tests #3120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add a short README.md to the directory, explaining what this is for, as it's not immediately obvious from the code.
Other than that, this looks good to me. I considered using some off the shelf application instead, but I think that'd be a comparable amount of work, and less clarity on how it was used.
@pavolloffay @jaronoff97 can you check this out and see if you're ok with it?
Description: New app for testing that the collector was able to get secret auth details from the target allocator when communication is done over mTLS
Part of a solution for #1669
Testing:
Documentation: