Support for Configuring imagePullSecrets for Collector and Agents with CRDs #3199
Conversation
|
@dvdlevanon-miggo thank you for your PR :D Can you make sure to sign the CLA so we can run the rest of the test suite? |
|
@dvdlevanon-miggo for your helm-charts question... that gets updated after the operator is released by the release manager, no need for you to worry about it :) |
…port-image-pull-secrets-in-crds
| // +optional | ||
| // +listType=map | ||
| // +listMapKey=name | ||
| ImagePullSecrets []v1.LocalObjectReference `json:"imagePullSecrets,omitempty"` |
There was a problem hiding this comment.
Does this need to be a list? It is related to a single image
There was a problem hiding this comment.
The official Kubernetes Pod API uses a list for imagePullSecrets. Aligning with this standard ensures consistency and compatibility with existing Kubernetes practices, allowing for greater flexibility and future-proofing the configuration.
| // ImagePullSecrets is an optional list of references to secrets in the same namespace to use for pulling any of the images used by this PodSpec. | ||
| // If specified, these secrets will be passed to individual puller implementations for them to use. | ||
| // More info: https://kubernetes.io/docs/concepts/containers/images#specifying-imagepullsecrets-on-a-pod | ||
| // +optional | ||
| // +listType=map | ||
| // +listMapKey=name | ||
| ImagePullSecrets []v1.LocalObjectReference `json:"imagePullSecrets,omitempty"` |
There was a problem hiding this comment.
v1alpha1 is frozen at this point, we should only add this field to the v1beta1 CRD.
…y-operator into support-image-pull-secrets-in-crds
…om/dvdlevanon/opentelemetry-operator into feat/issue-3127/support-image-pull-secrets-in-crds
|
@dvdlevanon-miggo looks like some failing unit tests |
| change_type: enhancement | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opamp, github action) | ||
| component: crds |
There was a problem hiding this comment.
This should be collector, auto-instrumentation
| component: crds | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Support for Configuring imagePullSecrets for Collector and Agents with CRDs |
There was a problem hiding this comment.
Support for configuring imagePullSecrets for collector and auto-instrumentation images
| @@ -39,6 +40,11 @@ func DaemonSet(params manifests.Params) (*appsv1.DaemonSet, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| imagePullSecrets := params.OtelCol.Spec.ImagePullSecrets | |||
| if params.OtelCol.Spec.ImagePullSecrets == nil { | |||
| imagePullSecrets = []v1.LocalObjectReference{} | |||
There was a problem hiding this comment.
Why do we need to assign it an empty list if it is null? This does not seem necessary
|
The CI failed |
|
@dvdlevanon @dvdlevanon-miggo i'd love to get this merged, would you be able to fix the failing tests so we can get this? |
Description: Support for Configuring imagePullSecrets for Collector and Agents with CRDs
Link to tracking Issue(s): #3127
Testing:
make testmake e2eDocumentation: The api.md generated and pushed.
This pull request adds the imagePullSecrets to the CRDs of both the Collector and Instrumentation. I have followed the contribution guidelines and have run make test, make lint, make fmt, and other necessary checks.
However, I am unsure about the process for updating the CRDs in the Helm charts repository. Does this update occur automatically based on the CRDs generated in this repository?
Additionally, I have the same question regarding the documentation. What is the process for updating the Helm charts and the corresponding documentation? I would appreciate any guidance on how to proceed with these updates.