Bump k8s dependencies to 1.31.0 #3234
Conversation
swiatekm
force-pushed
the
deps/bump-k8s-dependencies
branch
from
99d5ed2
to
c713083
Compare
|
I don't really understand what's going on with the |
Also bump controller-runtime to 0.19.0.
swiatekm
force-pushed
the
deps/bump-k8s-dependencies
branch
from
c713083
to
236f4e5
Compare
| verbs: | ||
| - get | ||
| - patch | ||
| - update | ||
| - apiGroups: | ||
| - opentelemetry.io | ||
| resources: | ||
| - opentelemetrycollectors | ||
| verbs: | ||
| - get | ||
| - list | ||
| - patch | ||
| - update | ||
| - watch | ||
| - apiGroups: | ||
| - opentelemetry.io | ||
| resources: | ||
| - opentelemetrycollectors/finalizers | ||
| verbs: | ||
| - get | ||
| - patch | ||
| - update | ||
| - apiGroups: | ||
| - opentelemetry.io | ||
| resources: |
There was a problem hiding this comment.
Why are those not needed anymore?
There was a problem hiding this comment.
This section was merged with the one for Instrumentations. I guess the new version of controller-tools is better at arranging RBAC rules.
| @@ -3284,6 +3313,8 @@ spec: | |||
| type: object | |||
| type: array | |||
| x-kubernetes-list-type: atomic | |||
| required: | |||
| - managementState | |||
There was a problem hiding this comment.
Does this mean that users will always need to provide the .spec.managementState field when creating an OpenTelemetryCollector?
There was a problem hiding this comment.
No, managementState has a default, and that applies if it's not set by the user. Otherwise, all the E2E tests would fail.
Worth noting that I had to change one test which did a kubectl replace. That command does not apply defaults, and in that case you do need to set managementState manually. I just changed it into an apply instead.
Also bump controller-runtime to 0.19.0. This also required upgrading controller-tools to 0.16.1.
Supersedes #3233.