-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s dependencies to 1.31.0 #3234
Bump k8s dependencies to 1.31.0 #3234
Conversation
99d5ed2
to
c713083
Compare
I don't really understand what's going on with the |
Also bump controller-runtime to 0.19.0.
c713083
to
236f4e5
Compare
verbs: | ||
- get | ||
- patch | ||
- update | ||
- apiGroups: | ||
- opentelemetry.io | ||
resources: | ||
- opentelemetrycollectors | ||
verbs: | ||
- get | ||
- list | ||
- patch | ||
- update | ||
- watch | ||
- apiGroups: | ||
- opentelemetry.io | ||
resources: | ||
- opentelemetrycollectors/finalizers | ||
verbs: | ||
- get | ||
- patch | ||
- update | ||
- apiGroups: | ||
- opentelemetry.io | ||
resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are those not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section was merged with the one for Instrumentations. I guess the new version of controller-tools is better at arranging RBAC rules.
@@ -3284,6 +3313,8 @@ spec: | |||
type: object | |||
type: array | |||
x-kubernetes-list-type: atomic | |||
required: | |||
- managementState |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that users will always need to provide the .spec.managementState
field when creating an OpenTelemetryCollector
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, managementState
has a default, and that applies if it's not set by the user. Otherwise, all the E2E tests would fail.
Worth noting that I had to change one test which did a kubectl replace
. That command does not apply defaults, and in that case you do need to set managementState
manually. I just changed it into an apply
instead.
Also bump controller-runtime to 0.19.0. This also required upgrading controller-tools to 0.16.1.
Supersedes #3233.