Set OTEL_LOGS_EXPORTER for python #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this fixing a bug or is it just to be aligned with other injection code? |
pavolloffay
reviewed
Oct 7, 2024
pavolloffay
reviewed
Oct 8, 2024
xrmx
commented
Oct 8, 2024
iblancasa
approved these changes
Oct 10, 2024
|
@xrmx it looks like you have some E2E test failures related to the order of env variables in containers. |
xrmx
force-pushed
the
setup-python-otel-logs-exporter
branch
from
26acf2b
to
b474a15
Compare
xrmx
force-pushed
the
setup-python-otel-logs-exporter
branch
from
a3c8b64
to
391ffc5
Compare
xrmx
force-pushed
the
setup-python-otel-logs-exporter
branch
from
391ffc5
to
aad65c0
Compare
swiatekm
approved these changes
Oct 15, 2024
xrmx
commented
Oct 15, 2024
iblancasa
approved these changes
Oct 15, 2024
jaronoff97
approved these changes
Oct 15, 2024
Co-authored-by: Jacob Aronoff <[email protected]>
jaronoff97
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Set
OTEL_LOGS_EXPORTERtootlpto match the other signals. Logging is still disabled because it requiresOTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLEDset to true but that's a bigger change and may require a discussion.Link to tracking Issue(s):
Testing:
make test
Documentation: