-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic RBAC creation for kubeletstats receiver #3388
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Israel Blancas <[email protected]>
@@ -29,7 +29,6 @@ func TestScraperParsers(t *testing.T) { | |||
defaultPort int | |||
}{ | |||
{"prometheus", "__prometheus", 0}, | |||
{"kubeletstats", "__kubeletstats", 0}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should still be a scraper right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. It was removed from being a scraper in internal/components/receivers/helpers.go
and now is treated differently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it still shouldn't be returning a default port is what i mean. i.e. this test should still pass.
Link to tracking Issue(s):
Testing: added unit and E2E tests.