Add Ability to Override Service Names #939
Conversation
Signed-off-by: blakeromano-il <[email protected]>
|
|
|
I think some documentation update would help to make this annotation visible to the community :) |
Signed-off-by: blakeromano-il <[email protected]>
|
I just added some documentation in the readme about this 👍 @mat-rumian |
|
Is there anything else that is needed to get this approved? @mat-rumian |
|
I think @pavolloffay is the right person to ask :) |
|
@pavolloffay I made the changes you suggested. I am not super familiar with kuttl but if you feel like e2e tests are needed for this I can do my best to write one up. |
pkg/instrumentation/sdk.go
Outdated
| @@ -208,6 +208,10 @@ func (i *sdkInjector) injectCommonSDKConfig(ctx context.Context, otelinst v1alph | |||
| } | |||
|
|
|||
| func chooseServiceName(pod corev1.Pod, resources map[string]string, index int) string { | |||
| serviceNames := strings.Split(pod.Annotations["instrumentation.opentelemetry.io/service-name"], ",") | |||
There was a problem hiding this comment.
extract the annotation to a constant
There was a problem hiding this comment.
I did the split in the case of people with multiple containers. for you to be able to override the different container names
kuttl is super easy. This functionality deserves e2e tests. Let me know if you have any question about the e2e tests, I can help. |
| metadata: | ||
| name: java | ||
| spec: | ||
| env: |
There was a problem hiding this comment.
somebody can define OTEL_SERVICE_NAME here. What is the precedence order of setting the service name? We should document this in the readme and have a test.
There was a problem hiding this comment.
I honestly am not crazy sure on these answers. If you don't mind helping me fill the gaps @pavolloffay
There was a problem hiding this comment.
@blakeromano, I'm going to check what is missing to help you out.
There was a problem hiding this comment.
@yuriolisa I apologize been busy I was wondering if you had time to help me out 😸
|
@blakeromano i think this is going to be superseded by #2330 are you interested in continuing this work? |
Resolves #938