Expect exceptions in MessengerInstrumentation (#238)

* Expect exceptions in MessengerInstrumentation * Rectify wrong import
open-telemetry · Feb 15, 2024 · 5ef0ba0 · 5ef0ba0
1 parent 9e25568
commit 5ef0ba0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/Instrumentation/Symfony/src/MessengerInstrumentation.php b/src/Instrumentation/Symfony/src/MessengerInstrumentation.php
@@ -81,7 +81,7 @@ public static function register(): void
             post: static function (
                 MessageBusInterface $bus,
                 array $params,
-                Envelope $result,
+                ?Envelope $result,
                 ?\Throwable $exception
             ): void {
                 $scope = Context::storage()->scope();

diff --git a/src/Instrumentation/Symfony/tests/Integration/MessengerInstrumentationTest.php b/src/Instrumentation/Symfony/tests/Integration/MessengerInstrumentationTest.php
@@ -98,6 +98,25 @@ public function test_send_message($message, string $spanName, int $kind, array $
         }
     }
 
+    public function test_can_sustain_throw()
+    {
+        $bus = new class() implements MessageBusInterface {
+            public function dispatch(object $message, array $stamps = []): Envelope
+            {
+                throw new \Exception('booo!');
+            }
+        };
+
+        try {
+            $bus->dispatch(new SendEmailMessage('Hello Again'));
+        } catch (\Throwable $e) {
+            $this->assertCount(1, $this->storage);
+
+            /** @var ImmutableSpan $span */
+            $span = $this->storage[0];
+        }
+    }
+
     public function sendDataProvider(): array
     {
         return [