Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import the GCP resource detector class #3339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DylanRussell
Copy link

Description

Import a resource detector class for GCP. This change doesn't add any new code. It's re-exporting a package that is in the downstream GCP repo. This lets the GCP resource detector be loaded in via the "opentelemetry_resource_detector" entrypoint used here

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [X ] This change requires a documentation update

How Has This Been Tested?

n/a

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • [ X] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [ X] Followed the style guidelines of this project
  • [ X] Changelogs have been updated
  • [X ] Unit tests have been added
  • [X ] Documentation has been updated

@DylanRussell DylanRussell requested a review from a team as a code owner March 5, 2025 20:46
Copy link

CLA Not Signed

@xrmx
Copy link
Contributor

xrmx commented Mar 6, 2025

Why are we taking the burden of maintaining an empty package upstream just for a re-export? Why not defining the entry point in your package so that people interested can just use it?
I'm a user of the gcp resource detector and defining the entry point myself in my package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants