feat: call spans that produce reads query

open-telemetry · Oct 3, 2024 · 73b1f82 · 73b1f82
1 parent 18c3d5a
commit 73b1f82
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...ntation/active_record/lib/opentelemetry/instrumentation/active_record/patches/querying.rb b/...ntation/active_record/lib/opentelemetry/instrumentation/active_record/patches/querying.rb
@@ -20,13 +20,13 @@ class << base
           module ClassMethods
             if ::ActiveRecord.version >= Gem::Version.new('7.0.0')
               def _query_by_sql(...)
-                tracer.in_span("#{self}.find_by_sql") do
+                tracer.in_span("#{self} query") do
                   super
                 end
               end
             else
               def find_by_sql(...)
-                tracer.in_span("#{self}.find_by_sql") do
+                tracer.in_span("#{self} query") do
                   super
                 end
               end

diff --git a/instrumentation/active_record/test/instrumentation/active_record/patches/querying_test.rb b/instrumentation/active_record/test/instrumentation/active_record/patches/querying_test.rb
@@ -15,15 +15,15 @@
 
   before { exporter.reset }
 
-  describe 'find_by_sql' do
+  describe 'query' do
     it 'traces' do
       Account.create!
 
       User.find_by_sql('SELECT * FROM users')
       Account.first.users.to_a
 
-      user_find_spans = spans.select { |s| s.name == 'User.find_by_sql' }
-      account_find_span = spans.find { |s| s.name == 'Account.find_by_sql' }
+      user_find_spans = spans.select { |s| s.name == 'User query' }
+      account_find_span = spans.find { |s| s.name == 'Account query' }
 
       _(user_find_spans.length).must_equal(2)
       _(account_find_span).wont_be_nil