Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake in inline docs for legacy_span_names option #1143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shioyama
Copy link

@shioyama shioyama commented Sep 2, 2024

This looks to me to be incorrect: the default is false, with the span name matching the name of the notification itself. Switching it to true makes it reverse ordered and white space separated.

Copy link

CLA Not Signed

@kaylareopelle
Copy link
Contributor

Thank you for your contribution, @shioyama! Could you please sign the CLA?

@kaylareopelle
Copy link
Contributor

Hi @shioyama! Gentle reminder: Please sign the CLA so that we can accept your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants