-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Cow from InstrumentationScope #2275
base: main
Are you sure you want to change the base?
Remove Cow from InstrumentationScope #2275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Community Call:
- Lets keep builder as-is (i.e accept Cow.. )
- Hide fields from InstrumentationScope and offer pub getters.
9b3d790
to
7c69e5c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2275 +/- ##
=======================================
- Coverage 79.5% 79.5% -0.1%
=======================================
Files 121 121
Lines 20960 20968 +8
=======================================
+ Hits 16671 16676 +5
- Misses 4289 4292 +3 ☔ View full report in Codecov by Sentry. |
@@ -462,6 +462,28 @@ impl InstrumentationScope { | |||
attributes: None, | |||
} | |||
} | |||
|
|||
/// Instrumentation library name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Use the word "return" in the documentation for all the getters.
/// Instrumentation library name. | |
/// Returns the instrumentation library name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a CHANGELOG entry.
Fixes #2246
Changes
Removed the
InstrumentationScope
attributes from the public API and replaced them with getters.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes