-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force_flush to LogExporter #2276
Open
ThomsonTan
wants to merge
26
commits into
open-telemetry:main
Choose a base branch
from
ThomsonTan:add_force_flush_log
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
905ffbc
Add force_flush to LogExporter
ThomsonTan 7db1bd9
Merge branch 'main' into add_force_flush_log
lalitb 9cc40c1
Fix outdated comments
ThomsonTan 29f7ae6
Merge branch 'main' into add_force_flush_log
lalitb d67c975
Change force_flush to async
ThomsonTan 4ed3b73
Merge branch 'main' into add_force_flush_log
lalitb 125af29
Merge branch 'main' into add_force_flush_log
ThomsonTan 3aa6f8d
Remove async from force_flush in LogExporter
ThomsonTan 9984bec
Merge branch 'main' into add_force_flush_log
lalitb 6974ced
Merge branch 'main' into add_force_flush_log
ThomsonTan 9290828
Add force_flush exporter call to SimpleLogProcessor
ThomsonTan f1e861e
Merge branch 'main' into add_force_flush_log
ThomsonTan b258265
Merge branch 'main' into add_force_flush_log
ThomsonTan 71d4b40
Merge branch 'main' into add_force_flush_log
ThomsonTan 2987161
Merge remote-tracking branch 'origin' into add_force_flush_log
ThomsonTan 9b661f4
Merge branch 'main' into add_force_flush_log
ThomsonTan 1bf3d45
Address feedback
ThomsonTan 55dfd62
Fix build
ThomsonTan eae55fe
Remvoe force_flush call after export
ThomsonTan bacb628
Fix build
ThomsonTan 3d02d35
Merge branch 'main' into add_force_flush_log
lalitb b67e2b0
Fix parameters
ThomsonTan a154ce8
Remove unneeded reference
ThomsonTan 54bb9fa
Remove unnecessary mut
ThomsonTan 86d7058
Remove runtime::tokio
ThomsonTan 6e7e418
Fix test
ThomsonTan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not have a default implementation for this method. Otherwise, we could run into a situation where an exporter user goes through the documentation and calls
force_flush
with certain expectations that haven't been agreed upon by the exporter author.It looks like we have a default implementation for a few other methods as well such as
shutdown
andset_resource
. We should revisit them based on what we decide.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, we could run into a situation where an exporter user goes through the documentation and calls force_flush with certain expectations that haven't been agreed upon by the exporter author.
If the exporter author does not provide an implementation for flush, then they can document that right? Or the doc for Provider can be updated to merely state that it'll invoke flush on the processor, and the same for processor can state they will invoke the flush for exporter.
Default implementation seems reasonable to me, as not every exporter need to do something for flush.