BatchSpanProcessor with dedicated thread. #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2456 +/- ##
=======================================
+ Coverage 76.9% 77.2% +0.2%
=======================================
Files 123 124 +1
Lines 22581 23009 +428
=======================================
+ Hits 17379 17765 +386
- Misses 5202 5244 +42 ☔ View full report in Codecov by Sentry. |
|
Done |
There was a problem hiding this comment.
Copilot reviewed 7 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (9)
- opentelemetry-zipkin/src/exporter/mod.rs: Evaluated as low risk
- opentelemetry-sdk/benches/batch_span_processor.rs: Evaluated as low risk
- opentelemetry-sdk/src/trace/provider.rs: Evaluated as low risk
- opentelemetry-sdk/src/testing/trace/in_memory_exporter.rs: Evaluated as low risk
- examples/tracing-jaeger/src/main.rs: Evaluated as low risk
- examples/tracing-grpc/src/client.rs: Evaluated as low risk
- examples/tracing-grpc/src/server.rs: Evaluated as low risk
- opentelemetry-sdk/Cargo.toml: Evaluated as low risk
- opentelemetry-otlp/examples/basic-otlp/src/main.rs: Evaluated as low risk
lalitb
changed the title
cijothomas
reviewed
Dec 23, 2024
| runtime: R, | ||
| ) -> Self { | ||
| let batch = BatchSpanProcessor::builder(exporter, runtime).build(); | ||
| pub fn with_batch_exporter<T: SpanExporter + 'static>(self, exporter: T) -> Self { |
There was a problem hiding this comment.
this needs to called out in changelog.md file.
cijothomas
reviewed
Dec 23, 2024
| @@ -165,13 +164,12 @@ impl ZipkinPipelineBuilder { | |||
| /// Install the Zipkin trace exporter pipeline with a batch span processor using the specified | |||
| /// runtime. | |||
| #[allow(deprecated)] | |||
| pub fn install_batch<R: RuntimeChannel>( | |||
| pub fn install_batch( | |||
There was a problem hiding this comment.
please add this to changelog as this is breaking.
cijothomas
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2454
Changes
span_processor_with_async_runtime- which is enabled behind the feature-flag:experimental_trace_batch_span_processor_with_async_runtime. This is consistent with the batch-processor in logs, and periodic-reader in metrics. Feel free to ignore this during review. It's more of movement from one-file to another.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes