Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BatchLogProcessor with runtime to separate module #2463

Merged

Conversation

cijothomas
Copy link
Member

This makes the migration consistent with PeriodicReader as users need to enable feature-flag + add new module name.
Experimental BatchProcessor_with_runtime is moved to a separate module.

@cijothomas cijothomas requested a review from a team as a code owner December 21, 2024 02:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

opentelemetry-sdk/src/logs/mod.rs:16

  • [nitpick] The comment should be more specific. Consider updating it to: '/// Module for BatchLogProcessor with async runtime.'
/// Module for periodic reader with async runtime.
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 86.99690% with 84 lines in your changes missing coverage. Please review.

Project coverage is 76.9%. Comparing base (23f6ae2) to head (b3712e1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...y-sdk/src/logs/log_processor_with_async_runtime.rs 86.9% 84 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2463     +/-   ##
=======================================
+ Coverage   76.7%   76.9%   +0.1%     
=======================================
  Files        122     123      +1     
  Lines      22266   22581    +315     
=======================================
+ Hits       17093   17379    +286     
- Misses      5173    5202     +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 6209c06 into open-telemetry:main Dec 21, 2024
21 checks passed
@cijothomas cijothomas deleted the cijothomas/batchlog-move-module branch December 21, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants