Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit improvements to batchprocessors #2466

Merged

Conversation

cijothomas
Copy link
Member

Incrementally changing, to keep reviews easier. Lot more work left.

@cijothomas cijothomas requested a review from a team as a code owner December 23, 2024 21:34
@cijothomas cijothomas added the integration tests Run integration tests label Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.1%. Comparing base (ef49833) to head (f787817).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_processor.rs 42.8% 12 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2466     +/-   ##
=======================================
- Coverage   77.2%   77.1%   -0.1%     
=======================================
  Files        124     124             
  Lines      23016   23021      +5     
=======================================
+ Hits       17770   17771      +1     
- Misses      5246    5250      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the error reason fixed. Approving the PR to unblock.

@cijothomas cijothomas merged commit 8d5f222 into open-telemetry:main Dec 24, 2024
20 of 21 checks passed
@cijothomas cijothomas deleted the cijothomas/batchprocessor-nits branch December 24, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants