Avoid vec allocation during each export for BatchLogProcessor - Part 2 #2488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For batch export, we create an additional vec just to hold the references to
LogRecord
andInstrumentationScope
. This is needed because the constructor forLogBatch
only accepts a slice of tuples that are references toLogRecord
andInstrumentationScope
.BatchLogProcessor
already has a vec of ownedLogRecord
andInstrumentationScope
. This PR is an attempt to reuse that vec.Changes
LogBatch
which accepts a shared reference to a slice of boxed tuple of ownedLogRecord
andInstrumentationScope
.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes