Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeriodicReader shutdown modified to enforce timeout #2513

Conversation

cijothomas
Copy link
Member

Just hardcoded timeout now. Will make it configurable in next.

@cijothomas cijothomas requested a review from a team as a code owner January 14, 2025 23:17
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (5aa9120) to head (02478fd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/periodic_reader.rs 50.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2513     +/-   ##
=======================================
- Coverage   77.9%   77.9%   -0.1%     
=======================================
  Files        123     123             
  Lines      22949   22953      +4     
=======================================
+ Hits       17880   17881      +1     
- Misses      5069    5072      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utpilla utpilla merged commit f46bccc into open-telemetry:main Jan 15, 2025
20 of 21 checks passed
@cijothomas cijothomas deleted the cijothomas/periodicreader-shutdown-timeout branch January 15, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants