Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More integration tests added #2545

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jan 24, 2025

Changes

These are the current set of tests, with status (courtesy copilot):

Processor Type Runtime Flavor Logger Initialization Log Emission Client Type Worker Threads Status
Batch Tokio-Main Inside RT Inside RT Tonic, Reqwest-blocking 4 Working
Batch Tokio-Main Inside RT Inside RT Tonic, Reqwest-blocking 1 Working
Batch Tokio-Main Inside RT Inside RT Tonic, Reqwest-blocking Current Thread Working
Batch Tokio-Main Inside RT Outside RT Tonic, Reqwest-blocking 4 Working
Batch Tokio-Main Inside RT Outside RT Tonic, Reqwest-blocking 1 Working
Batch Tokio-Main Inside RT Outside RT Tonic, Reqwest-blocking Current Thread Working
Batch Non-Tokio-Main Inside RT Inside RT Tonic, Reqwest-blocking N/A Working
Batch Non-Tokio-Main Outside RT Outside RT Reqwest-blocking N/A Working
Batch Non-Tokio-Main Inside RT Outside RT Reqwest-blocking N/A Working
Simple Non-Tokio-Main Inside RT Outside RT Tonic, Reqwest-blocking N/A Working
Simple Non-Tokio-Main Inside RT Outside RT Reqwest, Hyper N/A Ignored
Simple Non-Tokio-Main Outside RT Outside RT Reqwest-blocking N/A Working
Simple Non-Tokio-Main Outside RT Outside RT Hyper, Tonic, Reqwest N/A Ignored
Simple Tokio-Main Inside RT Inside RT Reqwest-blocking 4 Ignored
Simple Tokio-Main Inside RT Inside RT Tonic, Reqwest, Hyper 4 Working
Simple Tokio-Main Inside RT Inside RT Tonic, Reqwest, Hyper 1 Working
Simple Tokio-Main Inside RT Inside RT Tonic, Reqwest, Hyper Current Thread Ignored

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner January 24, 2025 00:20
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.8%. Comparing base (95fa209) to head (a77840b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2545   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        122     122           
  Lines      23044   23044           
=====================================
  Hits       17931   17931           
  Misses      5113    5113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb added the integration tests Run integration tests label Jan 24, 2025
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

// logger initialization - Inside RT
// log emission - Outside RT
// Client - reqwest, hyper
#[ignore] // request and hyper client does not work without tokio runtime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add link to the open issue for easy tracking.

@cijothomas cijothomas merged commit 4c77c89 into open-telemetry:main Jan 24, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants