-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More integration tests added #2545
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2545 +/- ##
=====================================
Coverage 77.8% 77.8%
=====================================
Files 122 122
Lines 23044 23044
=====================================
Hits 17931 17931
Misses 5113 5113 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
// logger initialization - Inside RT | ||
// log emission - Outside RT | ||
// Client - reqwest, hyper | ||
#[ignore] // request and hyper client does not work without tokio runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets add link to the open issue for easy tracking.
Changes
These are the current set of tests, with status (courtesy copilot):
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes