Skip to content

Commit

Permalink
Do not require extensible Logger.Enabled parameters list (#4221)
Browse files Browse the repository at this point in the history
  • Loading branch information
pellared authored Oct 1, 2024
1 parent fbaf846 commit d6cb895
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ release.

- Define `Enabled` parameters for `Logger`.
([#4203](https://github.com/open-telemetry/opentelemetry-specification/pull/4203))
([#4221](https://github.com/open-telemetry/opentelemetry-specification/pull/4221))
- Make all fields as identifying for Logger. Previously attributes were omitted from being identifying.
([#4161](https://github.com/open-telemetry/opentelemetry-specification/pull/4161))

Expand Down
9 changes: 0 additions & 9 deletions specification/logs/bridge-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,6 @@ The API SHOULD accept the following parameters:
When only explicit Context is supported, accepting this parameter is REQUIRED.
- [Severity Number](./data-model.md#field-severitynumber) (optional)

Additional optional parameters can be added in the future, therefore,
the API MUST be structured in a way for these parameters to be added.

It SHOULD be possible to distinguish between an unspecified parameter value from
a parameter value set explicitly to a valid default value of given type
(e.g. distinguish unspecified attributes for empty attributes). The exception
from this rule is when the default value of given type is not seen as a valid
value like 0 for [Severity Number](./data-model.md#field-severitynumber).

This API MUST return a language idiomatic boolean type. A returned value of
`true` means the `Logger` is enabled for the provided arguments, and a returned
value of `false` means the `Logger` is disabled for the provided arguments.
Expand Down

0 comments on commit d6cb895

Please sign in to comment.