Define minimum stale time for issues/PRs in SIGs #1897
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -71,6 +71,13 @@ action, please provide the rationale for closing, and indicate that OP can | |||||||||
| re-open for discussion if there are additional info, justification and | ||||||||||
| questions. | ||||||||||
|
|
||||||||||
| Issues with no activity during 1 year can be considered stale | ||||||||||
| and can be closed. However, SIGs are free to use a longer period of time. | ||||||||||
|
Comment on lines
+74
to
+75
There was a problem hiding this comment. closed immediately or marked stale first?
Suggested change
There was a problem hiding this comment. I'd vow for closing them immediately. 1 year is rather enough time to be able to forget about them ;) There was a problem hiding this comment. Marking issue stale is a form of notification to people, who can react to it, come back and say "I'm still interested", which could signal the bot to remove stale marker. They technically can reply to a closed issue, but that won't reopen / extend the issue without manual intervention from repo owners (who can always close manually if necessary). I personally don't find it that useful to auto-close issues in the first place. Closing PRs makes sense because they rot much faster, but an issue might record just an idea on the roadmap, or even some registry like jaegertracing/jaeger#638. So if we introduce auto-close for issues I think it must be accompanied by a tagging mechanism that exempts certain issues from auto-close, like |
||||||||||
|
|
||||||||||
| Pull requests with no activity during 7 days can be marked stale, | ||||||||||
| and they should stay at least 7 days as stale before they can be closed. | ||||||||||
| Similarly to issues, SIGs are free to use longer periods of time. | ||||||||||
|
Comment on lines
+74
to
+79
There was a problem hiding this comment.
I think this should rather be defined in the repo guidelines in https://github.com/open-telemetry/community. There was a problem hiding this comment. We already have a lot regarding issues in this section - we can try to move it out in a follow up, however. |
||||||||||
|
|
||||||||||
| ## When Issues Get Stuck | ||||||||||
|
|
||||||||||
| Some issues are not directly related to a particular code change. If an | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that maintainers are not allowed to close issues faster? Regardless of the activity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only about closing due to it being stale. If the issue has been sufficiently addressed it can be closed anyway regardless of this.