GraphQL Attributes #3668
Closed
GraphQL Attributes #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Aug 18, 2023
|
Semantic conventions have moved to a new repository, please move your CL there (and check the header of the semconv files): |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of attributes for GraphQL was slim, its useful attribute other values such as the args, context value, and return type for each operation.
I came here from trying to update graphql-otel to be spec compliant rocket-connect/graphql-otel#3
I also found that the guild tooling is also using a slightly different convention https://github.com/n1ru4l/envelop/blob/main/packages/plugins/opentelemetry/src/index.ts#L12
Could we use this PR as a starting point to standardize naming conventions here?