Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add definition for standard output span exporter #3740

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Oct 26, 2023

Changes

I couldn't find the definition for a standard output exporter for the trace signal, so I'm submitting one. This is mostly a copy of the definition already present for the metrics exporter. It doesn't specify a format for the output itself.

@codeboten codeboten requested review from a team October 26, 2023 16:34
This is mostly a copy of the definition already present for the metrics exporter. It doesn't specify a format for the output itself.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/add-stdout-exporters-traces-logs branch from 1fe871f to 59bfe95 Compare October 26, 2023 16:36
@codeboten codeboten changed the title add definition for standard output trace exporter add definition for standard output span exporter Oct 26, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
specification/trace/sdk_exporters/stdout.md Outdated Show resolved Hide resolved
codeboten pushed a commit to codeboten/opentelemetry-specification that referenced this pull request Oct 26, 2023
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it.

Signed-off-by: Alex Boten <[email protected]>
@carlosalberto
Copy link
Contributor

LGTM - don't have a name preference, and I'm actually slightly afraid it's rather late to change the name of all console exporters 😥

@jack-berg jack-berg self-requested a review November 9, 2023 03:25
@jack-berg
Copy link
Member

Will merge this tomorrow if there are no additional comments.

@carlosalberto carlosalberto merged commit cf79597 into open-telemetry:main Nov 17, 2023
7 checks passed
carlosalberto pushed a commit that referenced this pull request Nov 20, 2023
## Changes

I couldn't find the definition for a standard output exporter for the
logging signal, so I'm submitting one. This is mostly a copy of the
definition already present for the metrics exporter. It doesn't specify
a format for the output itself.

Similar to
#3740
codeboten pushed a commit to codeboten/opentelemetry-specification that referenced this pull request Nov 21, 2023
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it.

Signed-off-by: Alex Boten <[email protected]>
carlosalberto pushed a commit that referenced this pull request Nov 27, 2023
## Changes

This PR is a follow up to
#3740
and
#3741.
As some languages (the ones I looked at were: python, js, ruby) already
support the `console` type of exporter, I thought it would be good if
the spec confirmed it.
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
)

## Changes

I couldn't find the definition for a standard output exporter for the
logging signal, so I'm submitting one. This is mostly a copy of the
definition already present for the metrics exporter. It doesn't specify
a format for the output itself.

Similar to
open-telemetry#3740
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…#3742)

## Changes

This PR is a follow up to
open-telemetry#3740
and
open-telemetry#3741.
As some languages (the ones I looked at were: python, js, ruby) already
support the `console` type of exporter, I thought it would be good if
the spec confirmed it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.