logs: Remove Events operations in favor of making whole Logger user-facing #4352
+11
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
trask
approved these changes
Jan 9, 2025
reyang
approved these changes
Jan 9, 2025
cijothomas
approved these changes
Jan 10, 2025
lmolkova
approved these changes
Jan 11, 2025
breedx-splk
approved these changes
Jan 14, 2025
|
please wait to merge until at least Thu, Jan 16, in order to give @MSNev time to check in with the JS SIG on Wed, Jan 15 |
tedsuo
approved these changes
Jan 14, 2025
dashpole
approved these changes
Jan 14, 2025
MrAlias
approved these changes
Jan 15, 2025
@nev has confirmed #4352 (comment), merging the PR now. |
dmathieu
approved these changes
Jan 16, 2025
pellared
added a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Jan 17, 2025
Reason: open-telemetry/opentelemetry-specification#4352 Prior-art: #6018 Support for `EventName` field will be added in separate PRs.
This was referenced Jan 20, 2025
Merged
carlosalberto
added a commit
that referenced
this pull request
Jan 22, 2025
### Logs - Remove the deprecated Events API and SDK in favor of having Events support in the Logs API and SDK. ([#4353](#4353)) - Remove `Logger`'s Log Instrumentation operations. ([#4352](#4352)) - Make all `Logger` operations user-facing. ([#4352](#4352)) ### SDK Configuration - Clarify that implementations should interpret timeout environment variable values of zero as no limit (infinity). ([#4331](#4331))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4234
Fixes #4275
Fixes #4199
Related to #4357
This PR fixes more issues while making the design simpler than:
It does not break anything which was agreed on in https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/0265-event-vision.md.
I think we have gathered enough use cases to make emitting log records user-facing:
Other related OTEP PR:
Here is an OTel Go prototype pre-approved by @open-telemetry/go-maintainers :
I want to add that the other prototype following the current specification was not found acceptable for OTel Go SIG: