Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Headers were not being properly sent in OtlpHttpLogExporter #513

Conversation

nachoBonafonte
Copy link
Member

Fix Headers were not being properly sent in OtlpHttpLogExporter or StableOtlpMetricExporter

Given some xcformat love to some related files

Fixes #492

…ableOtlpMetricExporter

Given some xcformat love to some related files

Fixes open-telemetry#492
* main:
  Revert automatic version number (open-telemetry#511)
  Removed duplicate appending of log records (open-telemetry#504)

# Conflicts:
#	Sources/Exporters/OpenTelemetryProtocolHttp/logs/OtlpHttpLogExporter.swift
Copy link
Contributor

@vvydier vvydier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vvydier
Copy link
Contributor

vvydier commented Feb 2, 2024

@davidngoshadow Can you confirm if this fixes your issue #492
Thanks

@davidngoshadow
Copy link

@vvydier Yes it works perfectly !

@nachoBonafonte nachoBonafonte merged commit 297d91f into open-telemetry:main Feb 8, 2024
5 checks passed
@nachoBonafonte nachoBonafonte deleted the fix-Headers-not-sent-in-HTTP branch February 8, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers not sent in HTTP
3 participants