Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL analysis workflow for security scanning #652

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Ytemiloluwa
Copy link

@Ytemiloluwa Ytemiloluwa commented Dec 10, 2024

This PR adds a GitHub Actions workflow for running CodeQL analysis on the codebase to identify security vulnerabilities. The workflow is configured to automatically run on every push to the main branch and on pull requests targeting the main branch. It leverages the github/codeql-action to scan the repository for potential security issues in the Swift code.
Closes #565

Changes made:

  • Added a .github/workflows/codeql-analysis.yml file.
  • Configured the CodeQL analysis to run on pushes to main and pull requests targeting main.
  • Set up CodeQL to scan the repository specifically for Swift code.

Copy link

linux-foundation-easycla bot commented Dec 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@nachoBonafonte
Copy link
Member

It failed to run

@Ytemiloluwa
Copy link
Author

It failed to run

I made an update, but the workflow needs approval.

@nachoBonafonte
Copy link
Member

Yhe CodeQL analysis still fails tu run properly

@Ytemiloluwa
Copy link
Author

Yhe CodeQL analysis still fails tu run properly

The error has been fixed. all should be good now

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Ytemiloluwa
Copy link
Author

Hi maintainers, @nachoBonafonte @bryce-b @vvydier

I've implemented the CodeQL security scanning workflow as requested in issue #565. The CodeQL workflow is now:

  • Successfully set up and running
  • Using GitHub's recommended configuration for Swift analysis
  • Passing its security scanning checks
  • Running on macos-latest for proper Swift code analysis

The CodeQL bot has confirmed successful setup of code scanning, indicating that security analysis results will be available in the Security tab once merged.

Note: I notice the Build and Test workflow is failing, but this appears unrelated to the CodeQL workflow changes since I only modified the CodeQL analysis file.

Please review when you have a chance. Let me know if you'd like any adjustments to the CodeQL configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GHA workflow for security scans with CodeQL
2 participants