Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify OTLP/gRPC endpoint configuration option handling #4400

Open
pellared opened this issue Nov 15, 2023 · 6 comments
Open

Clarify OTLP/gRPC endpoint configuration option handling #4400

pellared opened this issue Nov 15, 2023 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@pellared
Copy link
Member

pellared commented Nov 15, 2023

I've had users ask why the path is ignored for gRPC. Its not clear to new gRPC users that the path is derived from the proto spec for the service. Do you think its worth elaborating on that here and indicating which parts of the URL are honored for gRPC? Or maybe alternatively there's some gRPC doc we can point to?

Originally posted by @jack-berg in open-telemetry/opentelemetry-specification#3739 (comment)

I think that we can add a reference to https://github.com/grpc/grpc/blob/master/doc/naming.md. We can also add a notice that gRPC endpoint is NOT an URL therefore it does not understand e.g. the "path" URL component.

@pellared
Copy link
Member Author

You can assign me to this issue and set appropriate labels.

@tigrannajaryan
Copy link
Member

I am not sure this explanation belongs to spec. May be can be useful in https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md

@tigrannajaryan
Copy link
Member

I guess it would be useful to have that sort of info on this page: https://opentelemetry.io/docs/concepts/sdk-configuration/otlp-exporter-configuration/

@austinlparker austinlparker transferred this issue from open-telemetry/opentelemetry-specification Apr 30, 2024
@austinlparker
Copy link
Member

This is a documentation issue @svrnm @cartermp please assign appropriately

@svrnm
Copy link
Member

svrnm commented May 2, 2024

Yeah, +1 what @tigrannajaryan suggested to have that mentioned in the SDK Configuration page, we might spread it from there to other pages

@svrnm svrnm added the help wanted Extra attention is needed label May 2, 2024
@pellared
Copy link
Member Author

pellared commented May 7, 2024

Unassigning myself as I continuously have other stuff which IMO has bigger priority.

@pellared pellared removed their assignment May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants