Clarify OTLP/HTTP endpoint configuration option handling #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
pirgeo
reviewed
Oct 31, 2023
Co-authored-by: Georg Pirklbauer <[email protected]>
MrAlias
reviewed
Nov 2, 2023
pellared
changed the title
pellared
changed the title
pellared
changed the title
jack-berg
reviewed
Nov 14, 2023
MrAlias
reviewed
Nov 14, 2023
|
@pirgeo @jack-berg @MrAlias Can please you take another look? |
jack-berg
approved these changes
Nov 15, 2023
pirgeo
approved these changes
Nov 16, 2023
MrAlias
approved these changes
Nov 28, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…try#3739) 1. The specification should define how the configuration options should handle the value. We cannot force the user to not set an env var value. 2. Changed `endpoint` to `option` to make it more clear that the specification says how the configuration option should work. 3. Initially I thought about defining `MUST not accept a path that contains other parts` (instead of `MAY`), but I have not found any OTLP exporter that makes such a detailed validation ([Java](https://github.com/open-telemetry/opentelemetry-java/blob/main/exporters/common/src/main/java/io/opentelemetry/exporter/internal/ExporterBuilderUtil.java), [.NET](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs), [Python](https://github.com/open-telemetry/opentelemetry-python/blob/main/exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/trace_exporter/__init__.py)). _I was even considering to remove this statement, but I feel that it may be a too drastic change._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endpointtooptionto make it more clear that the specification says how the configuration option should work.MUST not accept a path that contains other parts(instead ofMAY), but I have not found any OTLP exporter that makes such a detailed validation (Java, .NET, Python). I was even considering to remove this statement, but I feel that it may be a too drastic change.