-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review visualizations for dark/light mode compatibility #5438
Review visualizations for dark/light mode compatibility #5438
Conversation
thanks, a few comments:
|
…o customize-visualizations Update the branch EXIT
…opentelemetry.io into customize-visualizations
@svrnm, I have implemented the changes you recommended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes here, thanks!
@chalin thank you |
Hi @SusanGithaigaN - I'll let @svrnm respond (since he has been leading the Outreachy efforts) once he is back. |
This pr resolves issue #5361 and adjusts the background color of the visualizations, ensuring they adapt to both light and dark modes. The overall color scheme and theme remain unchanged.
##Demo
Review.visualizations.for.dark_light.mode.compatibility.5361.webm