Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review visualizations for dark/light mode compatibility #5438

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

SusanGithaigaN
Copy link
Contributor

This pr resolves issue #5361 and adjusts the background color of the visualizations, ensuring they adapt to both light and dark modes. The overall color scheme and theme remain unchanged.

##Demo

Review.visualizations.for.dark_light.mode.compatibility.5361.webm

@SusanGithaigaN SusanGithaigaN requested a review from a team as a code owner October 18, 2024 13:14
@opentelemetrybot opentelemetrybot requested review from a team and TylerHelmuth and removed request for a team October 18, 2024 13:14
@SusanGithaigaN
Copy link
Contributor Author

@chalin, @svrnm, I have implemented the changes you recommended.

@svrnm
Copy link
Member

svrnm commented Oct 18, 2024

thanks, a few comments:

@opentelemetrybot opentelemetrybot requested a review from a team October 18, 2024 19:03
@SusanGithaigaN
Copy link
Contributor Author

thanks, a few comments:

@svrnm, I have implemented the changes you recommended.
I'm now working on the dedicated pr for the image on the instrumentation scope page.

@svrnm svrnm added this pull request to the merge queue Oct 25, 2024
Merged via the queue into open-telemetry:main with commit c705446 Oct 25, 2024
17 checks passed
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes here, thanks!

@SusanGithaigaN
Copy link
Contributor Author

@chalin thank you
Can I create another pr for other registry related UI issues?

@chalin
Copy link
Contributor

chalin commented Oct 30, 2024

Hi @SusanGithaigaN - I'll let @svrnm respond (since he has been leading the Outreachy efforts) once he is back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants