-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps to v0.120.0 for collector #292
base: main
Are you sure you want to change the base?
Bumps to v0.120.0 for collector #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaronoff97 did you run make genotelarrowcol
? When I've done these upgrades in the past this has also caused changes in collector/cmd/otelarrowcol/components.go
which I don't see here. I've forgotten in the past leading to 2 PRs for the upgrade from 117 to 119: see #285 and #286.
nope i hadn't. I just did! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for beating me to it!
There's a bug with the newest mdatagen so I still need to import
manually