Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps to v0.120.0 for collector #292

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jaronoff97
Copy link
Contributor

@jaronoff97 jaronoff97 commented Feb 19, 2025

There's a bug with the newest mdatagen so I still need to import

// Had to add these two lines manually for some reason - mdatagen didn't import them properly
"go.opentelemetry.io/otel/metric"
"github.com/open-telemetry/otel-arrow/collector/processor/concurrentbatchprocessor/internal/metadata"

manually

Copy link
Collaborator

@drewrelmas drewrelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaronoff97 did you run make genotelarrowcol? When I've done these upgrades in the past this has also caused changes in collector/cmd/otelarrowcol/components.go which I don't see here. I've forgotten in the past leading to 2 PRs for the upgrade from 117 to 119: see #285 and #286.

@jaronoff97
Copy link
Contributor Author

nope i hadn't. I just did!

Copy link
Collaborator

@drewrelmas drewrelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for beating me to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants