GenAI events - yamlify body definitions and cosmetic examples improvements #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
changed the title
lmolkova
commented
Oct 16, 2024
lmolkova
commented
Oct 17, 2024
lmolkova
force-pushed
the
gen-ai-events-improvements
branch
from
e225e77
to
c62aa16
Compare
xrmx
approved these changes
Oct 21, 2024
lmolkova
commented
Oct 21, 2024
| requirement_level: | ||
| conditionally_required: if available and not equal to `assistant`. | ||
| - id: tool_calls | ||
| type: map # TODO: it's an array |
There was a problem hiding this comment.
TODO: this is blocker - need to release new weaver that supports it
There was a problem hiding this comment.
Is this still blocked and the PR ready for review?
There was a problem hiding this comment.
the PR is ready for review, but the tooling is not ready for us to define array of map type. So even if you review, we can't merge it yet
nirga
approved these changes
Oct 31, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge requirement checklist
[chore]schema-next.yaml updated with changes to existing conventions.