[WIP] Add span rendering template and clean up span briefs and notes #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Oct 22, 2024
| brief: 'Tech-specific attributes for gRPC.' | ||
| brief: > | ||
| Semantic Conventions for [gRPC](https://grpc.io/) extend and override the | ||
| [RPC client and server spans](rpc-spans.md) |
There was a problem hiding this comment.
this is one of the several reasons we can't have nice things generate span kind in MD - we define spans without kind, but assume it can be client or server.
TODO: create issue to require kind and clean up stuff.
lmolkova
commented
Oct 22, 2024
| @@ -28,53 +34,30 @@ groups: | |||
| - ref: aws.request_id | |||
| requirement_level: recommended | |||
|
|
|||
| - id: dynamodb.shared | |||
There was a problem hiding this comment.
this group was never used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[chore]schema-next.yaml updated with changes to existing conventions.