Add known Kestrel connection error types #1548
Open
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
reviewed
Nov 5, 2024
| | `output_queue_size_exceeded` | The connection exceeded the output queue size and was closed with `INTERNAL_ERROR`. This can be caused by an excessive number of HTTP/2 stream resets. For more information, see [Microsoft Security Advisory CVE-2023-44487:](https://github.com/dotnet/runtime/issues/93303). |  | | ||
| | `request_headers_timeout` | Request headers timed out while waiting for headers to be received after the request started. Configured by `KestrelServerLimits.RequestHeadersTimeout`. |  | | ||
| | `response_content_length_mismatch` | The HTTP response body sent data that didn't match the response's `content-length` header. |  | | ||
| | `server_timeout` | The connection timed out with the `IConnectionTimeoutFeature`. |  | |
There was a problem hiding this comment.
Technically correct but not useful. What timeouts signal this?
There was a problem hiding this comment.
As far as I can tell nothing in aspnetcore calls IConnectionTimeoutFeature.SetTimeout. The API is there for apps to use.
How do you suggest the description is improved?
Tratcher
reviewed
Nov 5, 2024
Tratcher
reviewed
Nov 5, 2024
Tratcher
reviewed
Nov 5, 2024
| | `invalid_request_line` | The first line of an HTTP/1.1 request was invalid, potentially due to invalid content or exceeding the allowed limit. Configured by `KestrelServerLimits.MaxRequestLineSize`. |  | | ||
| | `invalid_settings` | The connection received an HTTP/2 or HTTP/3 `SETTINGS` frame with invalid settings. |  | | ||
| | `invalid_stream_id` | An HTTP/2 stream with an invalid stream ID was received. |  | | ||
| | `invalid_window_update_size` | The server received an HTTP/2 `WINDOW_UPDATE` frame that caused a flow-control window to exceed the maximum size. |  | |
There was a problem hiding this comment.
Tratcher
reviewed
Nov 5, 2024
noahfalk
approved these changes
Nov 5, 2024
Co-authored-by: Chris Ross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.NET 9 adds connection error reasons to Kestrel connection duration metric. This PR updates the spec with the known types.
Preview: https://github.com/JamesNK/semantic-conventions/blob/jamesnk/kestrel-error-reason/docs/dotnet/dotnet-kestrel-metrics.md#metric-kestrelconnectionduration (scroll down to
error.typetable)Merge requirement checklist
[chore]