Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CICD metrics #1681
base: main
Are you sure you want to change the base?
Add CICD metrics #1681
Changes from 9 commits
72b225b
1b10459
d820586
a2edc16
3e1537b
7d4affa
70f2bd6
1c4e584
2f9b857
65b854f
a044341
7330043
a243084
3a31dd9
66732c5
2e8ab02
1562dc6
dc09536
26d3064
a2202cd
cc76185
89f6a8f
81c4407
c1bc664
226b835
55414ee
fc48dd2
0be8d4d
996e809
b332638
cf67fd2
702ca16
b113166
adf29b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In many complex CI/CDs the workers are categorized by other attributes, such as the platform they run (
ubuntu
,windows
) the tooling they have installed (java
,go
) or other attributes.I lean towards leaving this attribute open (without pre-defined values). Also consider
class
as an alternative name to reflect its intention to group the workers into categories.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have renamed this attribute to
cicd.worker.class
in 26d3064.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now actually removed
cicd.worker.class
in b332638.See the discussion #1681 (comment) for reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
cicd.errors
name seems too broad - it seems it would cover all kinds of errors in all CI/CD system parts and then it stops being practical.The first time I read it, I assumed it to count pipeline run errors, but it's probably something else.
Wonder if we could limit the scope of this metric to something reasonable. E.g. should it be
cicd.controller.errors
? I could envision we'd want to differentiate per component, e.g. have acicd.scheduler.errors
, etcThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intended to count the errors from the CICD system (controller, scheduler, agent) in this metric and not errors from the pipeline run.
It is indeed good to be able to distinguish the different system components as well as errors from the pipeline runs.
Adriel also made a good point that it would be good to be able to count pipeline run errors separately from just the cicd.pipeline.run.duration with result=error because a single pipeline run might encounter several different errors (some recoverable and others not).
Most likely this will be a derived metric, eg. by using a span metrics connector on the pipeline run spans or count connector on the controller logs.
I will define the following metrics to cover these:
cicd.pipeline.run.errors
for errors encountered as part of the pipeline run executioncicd.system.errors
for errrors encountered in CICD system components with an attribute component (eg. scheduler, agent, controller, …)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in fc48dd2, 0be8d4d and 996e809.