Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relay account and tests #651
base: master
Are you sure you want to change the base?
relay account and tests #651
Changes from 4 commits
7421f97
514566b
1f7d92a
d132663
f4162e3
ced4d67
cbb4944
c3b4d7d
61d40f5
1cb1abf
23e1a9f
e1467ba
9cffcc5
631659b
b1a2a90
4177cd6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will reverse to
MultiLocation { parents: 0, interior: X1(AccountId32), }
, no?That means it will not convert back to the input if calling
RelaychainAccountId32Aliases.convert(location).reverse()
which would be desirable, no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good point, as the reverse path is not currently go through, I may miss here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after I change here to return
(1, AccountId32).into()
. If we config(...,AccountId32Aliases,RelaychainAccountId32Aliases)
, then reverse onAccountId
will always return(parents:0, X1(AccountId32))
. But when I change the order to(...,RelaychainAccountId32Aliases, AccountId32Aliases)
, then reverse onAccountId
will always return(parents:1, X1(AccountId32))
. this sounds no better solution if those two config has same trait bounds, unless we make them different.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've post an issue on polkadot: paritytech/polkadot#4296. would you mind to see if that's a potential problem? @KiChjang @apopiak