Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added release workflow #421

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

coderatul
Copy link
Contributor

don't know whether it would work or not because to check build has to run whihc needs docker credentials

@augustjohnson
Copy link
Collaborator

Ok, looking in the right direction.
I don't think "install dependencies" is a necessary step, because we don't even use pip, and we're not packaging up a wheel, so you can remove that.

Can you change the zip of the codebase name to be something more like "open5e-api-1.1.1.zip" or something?

I also think DRAFTING the release is probably a good idea, so I think the process would roughly be:
Tag a merge
which triggers this.
Approve a DRAFT after reviewing.

@augustjohnson
Copy link
Collaborator

Ah, sorry, remote the build step as well, I'm imagining literally just code (for now) is part of our release. There's no way at the moment to really use open5e as a dependency.

Copy link
Contributor Author

@coderatul coderatul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any review ? any changes to be made

@augustjohnson
Copy link
Collaborator

We'll test this out with 1.5.0

@augustjohnson augustjohnson merged commit 6a7552a into open5e:staging Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants