-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding variables for the number of charging stations #314
Adding variables for the number of charging stations #314
Conversation
…|Charging station|Public in technolgies.yaml
…|Charging Station|Public in technolgies.yaml
@jeremydumoulin I would advise you to request some reviewers to review or this PR may wait a long time. You could eg request @erikfilias @phackstock and myself (@phackstock is leading this nomenclature work and is the one who can merge, @erikfilias and myself have experienced the process in openentrance ) |
@sandrinecharousset : thank you for the advice, but it seems to me that I do not have enough rights to request specific reviewers. I should probably ask @phackstock for that. @danielhuppmann : Many thanks for following up on this PR. I have added private and semi-public stations to complete the sub-categorization, and also updated the variable descriptions for clarity. Best regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distinction between public, semi-public and private makes sense to me.
One final thought - does it make sense to name the variable as "Infrastructure|Transportation|Charging Station|...". It seems to be a bit different in nature from a "stock" like vehicles...
…the number of charging stations
Thanks for the quick feedback. Good point. I probably do not have enough experience with variable names to know which is the best option here. It seems that having "Infrastructure|Transportation|Charging Station|..." is indeed more relevant. Best |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! Will merge if @sandrinecharousset also approves.
@jeremydumoulin, thanks for the PR, just upgraded your rights to triage so you should be able to select reviewers. |
Thank you all for processing this PR and for your valuable comments. |
New variables related to the number of charging stations for electric vehicles, defined in the context of the OpenMod4Africa project, task 3.1.
The number of variables requested is deliberately small for the time being, as it is not yet clear if a higher granularity will be required (e.g.: by also adding chargers at home, at work, or by segmenting the type of charger regarding their technical characteristics).
Many thanks for considering this request. Happy for any comments/suggestions.