Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1680: Improve error when exporting through an account_link #1846

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kkoehn
Copy link
Contributor

@kkoehn kkoehn commented Jan 29, 2025

Added a more descriptive error message for the presumably most common error.

@kkoehn kkoehn self-assigned this Jan 29, 2025
@kkoehn kkoehn linked an issue Jan 29, 2025 that may be closed by this pull request
@kkoehn kkoehn requested a review from Dome-GER January 29, 2025 19:17
@kkoehn kkoehn force-pushed the 1680-proforma-export-an-invalid-api-token-is-not-reported-correctly branch from 7964ce7 to 1818ac3 Compare February 4, 2025 21:04
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (5cb21f1) to head (4b5dc99).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
+ Coverage   94.79%   94.80%   +0.01%     
==========================================
  Files         133      133              
  Lines        3345     3352       +7     
==========================================
+ Hits         3171     3178       +7     
  Misses        174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrSerth

This comment was marked as resolved.

@kkoehn kkoehn force-pushed the 1680-proforma-export-an-invalid-api-token-is-not-reported-correctly branch from 1818ac3 to c6ee504 Compare February 5, 2025 20:44
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the further adjustments. I can confirm that only escaped strings are returned. 👏

💁 Please keep in mind: I have not done a regular code review.

app/services/task_service/push_external.rb Outdated Show resolved Hide resolved
@kkoehn kkoehn force-pushed the 1680-proforma-export-an-invalid-api-token-is-not-reported-correctly branch from c6ee504 to 4b5dc99 Compare February 5, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProFormA Export: An invalid API token is not reported correctly
2 participants