refactor: moving files from database module to model module #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Darkeye14 There are some classes like
|
niyajali
requested changes
Dec 28, 2024
core/data/src/main/java/com/mifos/core/data/pagingSource/CenterListPagingSource.kt
Outdated
Show resolved
Hide resolved
Bhai, ive explained it on slack bhai |
|
@niyajali Review |
niyajali
requested changes
Jan 6, 2025
| import com.mifos.core.objects.client.Status | ||
| import com.mifos.core.objects.group.Center | ||
| import com.mifos.core.dbobjects.client.Status | ||
| import com.mifos.core.dbobjects.group.Center |
There was a problem hiding this comment.
Rename dbobject package to model
| @@ -10,7 +10,7 @@ | |||
| package com.mifos.core.data | |||
|
|
|||
| import android.os.Parcelable | |||
| import com.mifos.core.objects.noncore.DataTablePayload | |||
| import com.mifos.core.dbobjects.noncore.DataTablePayload | |||
There was a problem hiding this comment.
Move this files in network model package and why we need payload in database module if you needed that data class than rename to LoanEntity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA
WhatsApp.Video.2024-12-27.at.16.15.22_f262dee6.mp4