Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2466): background color of splash screen doesn't change with theme #2730

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions androidApp/src/main/res/drawable/splash_icon.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
-->
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
<item>
<color android:color="@color/white" />
<color android:color="@color/splash_background" />
</item>

<item
android:width="160dp"
android:height="160dp"
android:width="80dp"
android:height="80dp"
android:drawable="@drawable/mifos_splash_screen_logo"
android:gravity="center" />
</layer-list>
14 changes: 14 additions & 0 deletions androidApp/src/main/res/values-night/colors.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
Copyright 2025 Mifos Initiative

This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
If a copy of the MPL was not distributed with this file,
You can obtain one at https://mozilla.org/MPL/2.0/.

See https://github.com/openMF/mobile-mobile/blob/master/LICENSE.md
-->
<resources>
<color name="splash_background">@color/splash_background_dark</color>
<color name="splash_background_dark" >#FF1A1A1A</color>
</resources>
9 changes: 7 additions & 2 deletions androidApp/src/main/res/values/colors.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
<?xml version="1.0" encoding="utf-8"?><!--
Copyright 2024 Mifos Initiative

This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0.
Expand All @@ -9,6 +8,12 @@
See https://github.com/openMF/mobile-mobile/blob/master/LICENSE.md
-->
<resources>

//fix : splash background
<color name="splash_background">@color/splash_background_light</color>
<color name="splash_background_light">#FFFDFDF5</color>
<color name="splash_background_dark">#FF1A1A1A</color>

<color name="white">#ffffffff</color>
<color name="black">#000000</color>
<color name="background">#eaeaea</color>
Expand Down
2 changes: 1 addition & 1 deletion androidApp/src/main/res/values/splash.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
-->
<resources>
<style name="Theme.MifosSplash" parent="Theme.SplashScreen">
<item name="windowSplashScreenBackground">#FFFDFDF5</item>
<item name="windowSplashScreenBackground">@color/splash_background</item>
<item name="windowSplashScreenAnimatedIcon">@drawable/splash_icon</item>
<item name="postSplashScreenTheme">@style/AppTheme</item>
<item name="windowSplashScreenAnimationDuration">10</item>
Expand Down
Loading