Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the latest changes on kmp branch #2731

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Updating the latest changes on kmp branch #2731

merged 1 commit into from
Jan 5, 2025

Conversation

niyajali
Copy link
Collaborator

@niyajali niyajali commented Jan 5, 2025

Fixes - Jira-#Issue_Number

Didn't create a Jira ticket, click here to create new.

Please Add Screenshots If there are any UI changes.

Before After

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

* feat[notifications, clientCharges]: DB flow to room database

* fix: clientChargeRepositoryImpl test

* fix: module name, entity name

* fix: Dependency Guard

* fix: Database Implementation

* fix: Fix Test & Lint Issue

---------

Co-authored-by: Sk Niyaj Ali <[email protected]>
@niyajali niyajali changed the title Updating the latest changes on this branch Updating the latest changes on kmp branch Jan 5, 2025
@niyajali niyajali merged commit fefc6ec into kmp-impl Jan 5, 2025
15 of 16 checks passed
Copy link

github-actions bot commented Jan 5, 2025

Combined test coverage report

Overall Project 68.12% -11.03% 🍏
Files changed 33.2%

File Coverage
HomeRepositoryImp.kt 100% 🍏
ClientChargeRepositoryImp.kt 71.88% -28.13%
MifosNotification.kt 50% -38.46%
Charge.kt 41.11% -57.84%
NotificationRepositoryImp.kt 21.09% -75.78%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants