feat(core:model): Migrate model module to KMP #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyajali
requested changes
Jan 9, 2025
core/model/src/commonMain/kotlin/org/mifos/mobile/core/model/Parcelize.kt
Outdated
Show resolved
Hide resolved
core/model/src/commonMain/kotlin/org/mifos/mobile/core/model/OverloadSupport.kt
Outdated
Show resolved
Hide resolved
core/model/src/commonMain/kotlin/org/mifos/mobile/core/model/Expose.kt
Outdated
Show resolved
Hide resolved
core/model/src/commonMain/kotlin/org/mifos/mobile/core/model/entity/ChargeCalculationType.kt
Outdated
Show resolved
Hide resolved
HekmatullahAmin
force-pushed
the
MM-104
branch
from
6606c8b to
0e98b39
Compare
HekmatullahAmin
force-pushed
the
MM-104
branch
from
0e98b39 to
b2885d8
Compare
niyajali
requested changes
Jan 10, 2025
core/model/src/commonMain/kotlin/org/mifos/mobile/core/model/entity/Timeline.kt
Outdated
Show resolved
Hide resolved
niyajali
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Great work @HekmatullahAmin , this looks good to me, could be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#Issue_Number
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.