Apply suggestions from code review

Co-authored-by: Axel Huebl <[email protected]>
openPMD · May 6, 2022 · 76b6f05 · 76b6f05
1 parent 56bfa04
commit 76b6f05
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/Error.cpp b/src/Error.cpp
@@ -47,7 +47,10 @@ namespace error
     {}
 
     Internal::Internal(std::string const &what)
-        : Error("Internal error: " + what + "\nThis is a bug. Please report.")
+        : Error(
+              "Internal error: " + what +
+              "\nThis is a bug. Please report at ' "
+              "https://github.com/openPMD/openPMD-api/issues'.")
     {}
 } // namespace error
 } // namespace openPMD
diff --git a/src/IO/HDF5/HDF5IOHandler.cpp b/src/IO/HDF5/HDF5IOHandler.cpp
@@ -258,7 +258,8 @@ void HDF5IOHandlerImpl::createFile(
             break;
         case Access::READ_ONLY:
             // condition has been checked above
-            throw std::runtime_error("Control flow error");
+            throw std::runtime_error(
+                "[HDF5] Control flow error in createFile backend access mode.");
         }
 
         hid_t id{};
@@ -470,8 +471,8 @@ void HDF5IOHandlerImpl::createDataset(
                 status = H5Ldelete(node_id, name.c_str(), H5P_DEFAULT);
                 VERIFY(
                     status == 0,
-                    "[HDF5] Internal error: Failed to delete old dataset from "
-                    "group for overwriting.");
+                    "[HDF5] Internal error: Failed to delete old dataset '" +
+                        name + "' from group for overwriting.");
                 break;
             }
         }