Test APPEND mode in all backends for groupbased Series

openPMD · Jun 21, 2021 · 966b1b2 · 966b1b2
1 parent c358f31
commit 966b1b2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/include/openPMD/openPMD.hpp b/include/openPMD/openPMD.hpp
@@ -27,6 +27,7 @@ namespace openPMD {}
 // IWYU pragma: begin_exports
 #include "openPMD/Dataset.hpp"
 #include "openPMD/Datatype.hpp"
+#include "openPMD/Error.hpp"
 #include "openPMD/IterationEncoding.hpp"
 #include "openPMD/Iteration.hpp"
 #include "openPMD/Mesh.hpp"

diff --git a/test/SerialIOTest.cpp b/test/SerialIOTest.cpp
@@ -3980,8 +3980,17 @@ void append_mode( std::string const & extension )
     {
         Series write(
             "../samples/append." + extension, Access::APPEND, jsonConfig );
+        if( write.backend() == "ADIOS1" )
+        {
+            REQUIRE_THROWS_AS(
+                write.flush(), error::OperationUnsupportedInBackend );
+            // destructor will be noisy now
+            return;
+        }
+
         writeSomeIterations(
             write.writeIterations(), std::vector< uint64_t >{ 2, 3 } );
+        write.flush();
     }
     {
         Series read( "../samples/append." + extension, Access::READ_ONLY );
@@ -3991,8 +4000,8 @@ void append_mode( std::string const & extension )
 
 TEST_CASE( "append_mode", "[serial]" )
 {
-    // @todo test for file-based appending
-    append_mode( "json" );
-    // append_mode( "bp" );
-    //append_mode( "h5" );
+    for( auto const & t : testedFileExtensions() )
+    {
+        append_mode( t );
+    }
 }