Skip to content

ADIOS2 variable shape LocalValue #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Mar 11, 2024

Ref https://adios2.readthedocs.io/en/v2.9.2/components/components.html#shapes

This PR considers LocalValues in ADIOS2 merely an implementation detail, without actually exposing an API analogous to to how LocalValues work in ADIOS2.

The reasoning is:

  1. LocalValues are useful not only for their API, but also since they give a hint to ADIOS2 that the variable should be handled as metadata and take part e.g. in metadata aggregation. With this PR, datasets such as the particlePatches in PIConGPU (one single value per MPI rank) can be given to the metadata system without changing a single line of code in PIConGPU. This can be crucial in streaming setups: When each reading rank loads the entire dataset naively (without this setting), the data plane of SST will open a connection between every writer and reader for just a single value each. Better to aggregate.
  2. If needed at some point, a LocalValue-like API can still be exposed on top of this.

TODO

  • Documentation
  • Check usage of readOperators, m_operators

@franzpoeschel franzpoeschel force-pushed the adios2-local-values branch 3 times, most recently from a342b5d to 88b01e8 Compare March 12, 2024 10:50
@franzpoeschel franzpoeschel requested a review from ax3l April 22, 2024 15:12
@franzpoeschel franzpoeschel force-pushed the adios2-local-values branch from 164bf28 to 950da6d Compare May 8, 2024 13:32
@franzpoeschel franzpoeschel force-pushed the adios2-local-values branch from 950da6d to b0bf166 Compare May 21, 2024 14:58
@franzpoeschel franzpoeschel force-pushed the adios2-local-values branch 3 times, most recently from 4ea14da to 1ef0287 Compare December 17, 2024 10:49
@@ -760,6 +760,14 @@
}
}

TEST_CASE("issue_1744_unique_ptrs_at_close_time", "[serial]")

Check notice

Code scanning / CodeQL

Unused static function Note test

Static function C_A_T_C_H_T_E_S_T_16 is unreachable (
autoRegistrar17
must be removed at the same time)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants