fix(livenet): some fixes related to getting live image size (bsc#1235912) (SLE15-SP6:Update) #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some servers send `content-length` instead of `Content-Length`, so ignore the case. E.g.: ``` > curl -sIL https://pkg.adfinis.com/opensuse/tumbleweed/iso/openSUSE-Tumbleweed-DVD-x86_64-Snapshot20240118-Media.iso HTTP/2 200 server: nginx date: Fri, 19 Jan 2024 16:29:54 GMT content-type: application/octet-stream content-length: 4643094528 last-modified: Fri, 19 Jan 2024 03:34:00 GMT etag: "65a9eda8-114c00000" accept-ranges: bytes ```
…essage If `curl` fails to reach the URL of the live image, or if the header received does not provide `Content-Length`, the error message displayed is misleading. ``` [ 8.118432] dracut-initqueue[800]: /usr/sbin/livenetroot: line 21: / (1024 * 1024): syntax error: operand expected (error token is "/ (1024 * 1024)") ``` Therefore, split the calculation and provide proper error messages. Reported-by: Knut Anderssen <[email protected]> bsc#1235912
tblume
approved these changes
Jan 16, 2025
Sorry, did not mean to comment in this repo. |
Thanks Thomas. Just to clarify, by "implemented" do you mean "backported" to SP6? |
Yes, I mean backported. |
Ok, I'll start fixing the bug, the new feature has to go to factory first. |
aafeijoo-suse
merged commit 22e941b
into
openSUSE:SLE-15-SP6_Update
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
I'm not sure if we have to backport the feat: