Fixes for booting from iSCSI offload with bnx2i (bsc#1228086) (059) #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bnx2i iSCSI transport doesn't require networking to be set up in order to bring up iSCSI connections. Quite to the contrary, trying to bring up the network may actually disturb the iSCSI connection. This holds in particular for bnx2i device with NPAR (network partitioning) support, where a given network interface can be used for both iSCSI and regular networking. Setting certain network parameters like MTU on the network side can fatally disrupt an existing iSCSI connection. Even if this does not happen, trying to bring up the regular network interfaces is pointless because iSCSI won't be enabled over regular TCP/IP anyway. Trying to bring up the network interfaces and possibly failing delays booting unecessarily and may cause timeout, without benefit. Detect the bnx2i offload module at setup time and communicate it to parse-iscsiroot.sh using a new parameter, "rd.iscsi.transport". It's currently only effective for bnx2i. It might be useful for other transports as well, but we haven't been able to test the other transports as thoroughly as bnx2i. Signed-off-by: Martin Wilck <[email protected]> (cherry picked from commit dracut-ng/dracut-ng@cc2c48a) bsc#1228086
When booting from iSCSI, we don't need to wait for retries until all network interfaces are up. We can just attempt to activate iSCSI on those interfaces that are currently up (in the offload case like bnx2i, we can even try without any network interfaces). If the root fs is found, we can go on booting; otherwise, the iscsiroot script will be called again later anyway. Signed-off-by: Martin Wilck <[email protected]> (cherry picked from commit dracut-ng/dracut-ng@f30cf46) bsc#1228086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of dracut-ng/dracut-ng#1121 for Factory