Introduce download-retry and download-retry-wait settings in ZConfig #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlandres
requested changes
Jun 14, 2022
| @@ -37,6 +37,10 @@ SET( zypp_toplevel_SRCS | |||
| ) | |||
| INSTALL( FILES ${zypp_toplevel_headers} DESTINATION "${INCLUDE_INSTALL_DIR}/zypp-core" ) | |||
|
|
|||
| SET( zypp_base_private_HEADERS | |||
| base/private/configoption_p.h | |||
| ) | |||
There was a problem hiding this comment.
Ripping out the struct Options, placing them in a new header file and adding the header file to CMake schoul go into a separate commit. That's pure cleanup and not related to any fix.
|
|
||
| void set_download_max_silent_tries( long val, bool overrideDefault = false ) { | ||
| if ( val < 0 ) val = 0; | ||
| else if ( val > 10 ) val = 10; |
There was a problem hiding this comment.
If you introduce new limit's, then it must be documented. The accessor in ZConfig.h schould mention it. If it is also exposed in zypp.conf we should think twice whether we need to introduce a restriction (an break existing behavior). If so, it must be documented in the zypp.conf template we install in the system and the zypper man page must be checked, whether it mentions the value. And we need a good explanation why?.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.