setup a cleaner build environment #665
Conversation
|
Multiple build failures, relevant to this change. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982974 |
|
C.UTF-8 does not exist in older distros, so I'm not sure if it is a good idea to set it unconditionally. |
|
https://unix.stackexchange.com/questions/597962/how-widespread-is-the-c-utf-8-locale suggests Arch Linux does not have it - so it's not about the age of the distro |
|
True, but this pull request just patches the build-recipe-dsc file... |
|
but it's about the distribution executing it, or do I get this wrong? |
|
The change only affects |
build-recipe-dsc
Outdated
| @@ -95,7 +95,7 @@ dsc_build() { | |||
| # this allows the build environment to be manipulated | |||
| # and alternate build commands can be used | |||
| DSC_BUILD_CMD="$(queryconfig --dist "$BUILD_DIST" --archpath "$BUILD_ARCH" --configdir "$CONFIG_DIR" substitute dsc:build_cmd)" | |||
| test -z "$DSC_BUILD_CMD" && DSC_BUILD_CMD="dpkg-buildpackage -us -uc" | |||
| test -z "$DSC_BUILD_CMD" && DSC_BUILD_CMD="LC_ALL=C.UTF-8 dpkg-buildpackage -us -uc" | |||
There was a problem hiding this comment.
Is this the right place?
Shouldn't we change build-pkg-deb instead?
(but I am not sure who calls who to be honest)
There was a problem hiding this comment.
Probably both need to be changed; also build-pkg-deb needs to consistently run deb_chroot.
adrianschroeter
force-pushed
the
master
branch
from
e6ebce5
to
2a6beef
Compare
|
Any update on this? |
Multiple packages have run into build failures on our OBS. On closer inspection, it was concluded to be issues with the locale settings. These issues were never seen on the Debian buildd infrastructure because there the locale setting LC_ALL=C.UTF-8 is in use. This change keeps us closer to what is used in Debian buildds. openSUSE#665 Signed-off-by: Emanuele Aina <[email protected]>
To make the build environment a bit more reproducible, ensure the local timezone is set to UTC when building packages. Signed-off-by: Emanuele Aina <[email protected]>
…ilds Our OBS workers run under a `screen` session, which gives them an actual `$TERM` variable. Some packages like `color.js` then enable colored output, which confuses some other packages like `node-grunt-legacy-log` which use it in their testsuite and do not expect colored output. To avoid that, unset `TERM`. Signed-off-by: Emanuele Aina <[email protected]>
spymemcached package is FTBFS because a test expects a reverse lookup of 127.0.0.1 to return localhost, but current /etc/hosts configuration returns the hostname instead. Let's move this `hostname/ip` entry to the end of /etc/hosts so the reverse lookup of 127.0.0.1 returns localhost, which makes sense to be the default case usually. Signed-off-by: Ariel D'Alessandro <[email protected]>
rickysarraf
force-pushed
the
obs-build-rickysarraf/master
branch
from
7fbc66c
to
a68beef
Compare
|
Also added a couple of fixes we've been carrying in our setup for a while. |
rickysarraf
changed the title
Multiple packages have run into build failures on our OBS. On closer
inspection, it was concluded to be issues with the locale settings.
These issues were never seen on the Debian buildd infrastructure because
there the locale setting
LC_ALL=C.UTF-8is in use.This change keeps us closer to what is used in Debian buildds.
Signed-off-by: Ritesh Raj Sarraf [email protected]